Forum

Please consider registering
guest

Log In Register

Register | Lost password?
Advanced Search:

— Forum Scope —



— Match —



— Forum Options —




Wildcard usage:
*  matches any number of characters    %  matches exactly one character

Minimum search word length is 3 characters - maximum search word length is 84 characters

Topic RSS
Possible bug in admin.php
17 September, 2011
6:16 pm
jrwdev
Lakeport, CA
Member
Forum Posts: 4
Member Since:
17 September, 2011
Offline

when you navigate to the Add sermons page (admin.php?page=sermon-browser/new_sermon.php) the section at the top — Select an MP3 file here to have the Add Sermons form pre-filled using ID3 tags — the choose existing file input is not working correctly. When I choose a file from the uploads directory to import id3 info, I get an error that I do not have sufficient permissions. I am the admin on the account, and I made sure that the directory had permissions set correctly. After trying a few things with the url, I noticed that "admin.php" was missing. For some reason, when you submit the form with that input it redirects you to /wp-admin/?page=sermon-browser%2Fnew_sermon.php&getid3=2
The redirect is broken. It should redirect to /wp-admin/admin.php?page=sermon-browser%2Fnew_sermon.php&getid3=2
With this redirect, everything works fine. I tried to look in the admin.php file for the place where the redirect was broken…but there's too much there and I don't have time to spend debugging a plugin that I didn't write. I just thought you'd like to know.

Thanks

19 September, 2011
1:19 am
Joshua Kelley
Des Moines, Washington
Member
Forum Posts: 3
Member Since:
23 August, 2010
Offline

I just figured out this solution after a few months of frustration.

20 September, 2011
6:50 am
jrwdev
Lakeport, CA
Member
Forum Posts: 4
Member Since:
17 September, 2011
Offline

Ok…So I noticed that you're probably too busy to take care of minor bug fix requests like this, so I took it upon myself to read through all of the code for the plugin to understand how it works (admittedly, I could have just looked at the page source and done a "find" search for the affected lines). I found the problem.

On line 2520 of admin.php you currently have this code:

<form method="get" action="<?php echo admin_url();?>">

The problem here is that the form action is referring to http://www.example.com/wp-admin/ when it should be referring to http://www.example.com/wp-admi…../admin.php
When the line is modified to read:

<form method="get" action="<?php echo admin_url('admin.php');?>">

the form is now fixed and the bug removed.

Please include this fix in your next update, if you feel that I am correct in the diagnosis and prescription.

Best Regards,

Jon Wadsworth
http://www.jrwdev.com

P.S. I've used your sermonbrowser plugin for about 20 church websites, so I felt it my duty to pitch in. Thank you for your time on this wonderful plugin.

Forum Timezone: Europe/London

Most Users Ever Online: 40

Currently Online:
18 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

malpan: 2453

jogen: 2440

VanWatterson: 652

GeraldSebring: 364

LucasWoltman: 362

RandellFeenstra: 362

Member Stats:

Guest Posters: 7

Members: 2066

Moderators: 1

Admins: 1

Forum Stats:

Groups: 1

Forums: 2

Topics: 1071

Posts: 4045

Newest Members: Nixon Designs, zolaperry, tanec69, lbakyl, richdorm, Aaron Velasquez

Moderators: Ben Miller (387)

Administrators: Mark Barnes (425)

Comments are closed.