Forum

This forum is now read-only. Support is provided at https://wordpress.org/support/plugin/sermon-browser/

Please consider registering
guest

sp_LogInOut Log In sp_Registration Register

Register | Lost password?
Advanced Search

— Forum Scope —




— Match —





— Forum Options —





Minimum search word length is 3 characters - maximum search word length is 84 characters

sp_Feed Topic RSS sp_TopicIcon
Download Link not working for .MP3
20 August, 2013
12:06 am
jwoo1545
New Member
Members
Forum Posts: 1
Member Since:
19 August, 2013
sp_UserOfflineSmall Offline

Just a Minor issue.

When set up to display the audio player and download link. The download link displays for .mp3 files but not for .MP3, which is the same file format but with capitalization.

I found it easy to fix by adding(||substr($url, -4) == ".MP3") to the if clause on line 710 of frontend.php

I thought I would post this so I do not need to repeat the process every time the plugin gets updated, and to prevent the problem occurring for other people.

20 August, 2013
5:31 am
Ben Miller
Appleton, WI, USA
Moderator
Members

Moderators
Forum Posts: 1628
Member Since:
18 June, 2009
sp_UserOfflineSmall Offline

Good thinking.  I changed line 710 to this:

if ( strtolower(substr($url, -4)) == ".mp3" ) {

That way it will also work if someone uses ".Mp3" for the extension.

This will be in the next version.  Let me know if you see anything else that needs to be fixed.

Ben Miller, Pathways Church, Appleton, Wisconsin, USA
Read the new FAQ, last updated 11/21/2013
Announcing version 0.45.12

20 August, 2013
6:46 am
Ben Miller
Appleton, WI, USA
Moderator
Members

Moderators
Forum Posts: 1628
Member Since:
18 June, 2009
sp_UserOfflineSmall Offline

jw001545,

It looks like more needs to be done to get .MP3 to work.  Did you have to make any other code changes?  Could you post a link to your site, so I can see how it is working?

Ben Miller, Pathways Church, Appleton, Wisconsin, USA
Read the new FAQ, last updated 11/21/2013
Announcing version 0.45.12

22 August, 2013
9:07 pm
Ben Miller
Appleton, WI, USA
Moderator
Members

Moderators
Forum Posts: 1628
Member Since:
18 June, 2009
sp_UserOfflineSmall Offline

I stumbled across something while I was testing: If you are using the built-in WordPress 3.6 player (based on MediaElement.js), you can't use a file with capital letters in the extension.  You can read more about this in this Stack Exchange question.  I'm not sure if this is a bug or by-design.

Ben Miller, Pathways Church, Appleton, Wisconsin, USA
Read the new FAQ, last updated 11/21/2013
Announcing version 0.45.12

26 August, 2013
5:39 am
Ben Miller
Appleton, WI, USA
Moderator
Members

Moderators
Forum Posts: 1628
Member Since:
18 June, 2009
sp_UserOfflineSmall Offline

Follow-up for anyone following along: Apparently, a WordPress developer saw my question on Stack Exchange and patched WordPress to fix this problem.  So we have that to look forward to in a future version of WordPress.  :)

Ben Miller, Pathways Church, Appleton, Wisconsin, USA
Read the new FAQ, last updated 11/21/2013
Announcing version 0.45.12

Forum Timezone: Europe/London

Most Users Ever Online: 381

Currently Online:
15 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

Rich Brown: 358

Matt Schlueter: 93

Mindy: 72

Don Johnson: 65

anointed: 57

0be1: 55

Member Stats:

Guest Posters: 7

Members: 3188

Moderators: 1

Admins: 1

Forum Stats:

Groups: 1

Forums: 2

Topics: 1713

Posts: 7499

Newest Members:

marktest, deatles50, ValeriaGoodriz, dapedPup, oapedPup, Margarettoimb

Moderators: Ben Miller: 1628

Administrators: Mark Barnes: 435