Forum |Sermon Browser Plugin for WordPress

Please consider registering
guest

Home

Forum

Sermon Browser Support

Bug Report and Fix: uppercase .MP3 file extension causes Download link to go missing

Topic RSS

Bug Report and Fix: uppercase .MP3 file extension causes Download link to go missing

17 August, 2011
11:18 am

cflee

New Member

Forum Posts: 1

Member Since:
17 August, 2011

Offline

I couldn't find a bug tracker for this project so here goes.

Summary:
MP3 files with file extensions that are not exactly ".mp3" (ie not entirely lowercase) will not have the Download link appear after the audio player on single sermon pages.

Steps to reproduce:
0. Setup Sermon Browser plugin with audio player plugin
1. Create a sermon and upload one MP3 file attachment with extension ".MP3" (case sensitive)
2. View the single sermon page, ie not the entire sermon listing

Results:
Audio player works perfectly fine, but the "Download" link does not appear after the audio player.

Workaround/Fix:

— frontend.php (saved version)
+++ (current document)
@@ -695,7 +695,7 @@
function sb_print_url_link($url) {
echo '<div class="sermon_file">';
sb_print_url ($url);
- if (substr($url, -4) == ".mp3" && function_exists('ap_insert_player_widgets')) {
+ if (strtolower(substr($url, -4)) == ".mp3" && function_exists('ap_insert_player_widgets')) {
if (substr($url,0,7) == "http://") {
$param="url"; }
else {

It appears to be the only remaining instance where strtolower is not invoked for a comparison, involving .MP3 files.

All RSS

Forum Timezone: Europe/London

Most Users Ever Online: 40

Currently Online:
18 Guest(s)

Currently Browsing this Page:
1 Guest(s)